Skip to content

Adds RFC-15: snake_case - #655

Open
normanrz wants to merge 5 commits into
ome:mainfrom
normanrz:t3/rfc-15-snake-case-metadata
Open

normanrz wants to merge 5 commits into
ome:mainfrom
normanrz:t3/rfc-15-snake-case-metadata

Conversation

@normanrz

@normanrz normanrz commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This PR adds an RFC for switching the metadata field names to snake_case (consistently).

cc @DragaDoncila

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Automated Review URLs

@normanrz

normanrz commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Pinging @joshmoore for RFC number.

lubianat
lubianat previously approved these changes Nov 5, 2026

@lubianat lubianat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks well formatted afaik! thank you!

jo-mueller
jo-mueller previously approved these changes Nov 9, 2026

@jo-mueller jo-mueller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@lubianat

lubianat commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

A general comment here is that for new RFCs, we need to wait for Editorial Board (@joshmoore or @vuhlmann) to give an official "ok" before we can merge the PR

Comment thread rfc/15/index.md Resolved
Co-authored-by: Tiago Lubiana <[email protected]>
@normanrz
normanrz dismissed stale reviews from jo-mueller and lubianat via 98fe525 November 9, 2026 16:48
Comment thread rfc/15/index.md Resolved
DragaDoncila
DragaDoncila previously approved these changes Nov 17, 2026

@DragaDoncila DragaDoncila left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to finishing this read-through, apologies for the delay @normanrz.

All good to go on my end, minor tweaks can be ignored. Left one comment about extension-defined type values also not matching the identifier regex but can be addressed in follow-up.

Comment thread rfc/15/index.md Resolved
Comment thread rfc/15/index.md Resolved
Comment thread rfc/15/index.md Resolved
Comment thread rfc/15/index.md Resolved
Comment thread rfc/15/index.md Resolved
Comment thread rfc/15/index.md Resolved
@normanrz

Copy link
Copy Markdown
Contributor Author

Thanks @DragaDoncila!

Screenshot 2026-11-17 at 11 49 19 Is that the ok? :D

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants