Repository navigation
Conversation
Contributor
Automated Review URLs |
Contributor
Author
|
Pinging @joshmoore for RFC number. |
lubianat
previously approved these changes
Nov 5, 2026
lubianat
left a comment
Contributor
There was a problem hiding this comment.
looks well formatted afaik! thank you!
Contributor
|
A general comment here is that for new RFCs, we need to wait for Editorial Board (@joshmoore or @vuhlmann) to give an official "ok" before we can merge the PR |
lubianat
reviewed
Nov 9, 2026
Co-authored-by: Tiago Lubiana <[email protected]>
lubianat
reviewed
Nov 9, 2026
DragaDoncila
previously approved these changes
Nov 17, 2026
DragaDoncila
left a comment
There was a problem hiding this comment.
Finally got around to finishing this read-through, apologies for the delay @normanrz.
All good to go on my end, minor tweaks can be ignored. Left one comment about extension-defined type values also not matching the identifier regex but can be addressed in follow-up.
Co-authored-by: Draga Doncila Pop <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
Thanks @DragaDoncila!
Is that the ok? :D
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds an RFC for switching the metadata field names to snake_case (consistently).
cc @DragaDoncila